New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide vote choices for in-progress votes #1

Merged
merged 1 commit into from Jan 4, 2014

Conversation

3 participants
@salathe
Contributor

salathe commented Sep 8, 2012

<@ekneuss> can't we hide votes until voting phase is over ?
<@salathe> I don't see why not
<@Felipe>  just have to patch the voting module :p

This PR implements the suggestion above, to hide the choices that people made while a vote is in progress. A voter can see their own choice, but no-one else's.

After voting closes, the normal behaviour is resumed; showing all votes.

Poll with votes hidden

@php-pulls

This comment has been minimized.

php-pulls commented May 8, 2013

Comment on behalf of johannes at php.net:

test. ignore.

@bjori

This comment has been minimized.

Member

bjori commented Dec 31, 2013

Seriously. A year?
I guess I'll have to check PRs more frequently..

The patch no longer applies though.. Do you mind updating it?

@salathe

This comment has been minimized.

Contributor

salathe commented Jan 3, 2014

I have reapplied the patch against current master. (I'm on the train and can't test it, but everything should be a-okay) /cc @bjori

bjori added a commit that referenced this pull request Jan 4, 2014

Merge pull request #1 from salathe/salathe/hide-votes-in-progress
Hide vote choices for in-progress votes

* salathe/salathe/hide-votes-in-progress:
  Hide vote choices for in-progress votes

@php-pulls php-pulls merged commit 2c8876d into php:master Jan 4, 2014

@salathe salathe deleted the salathe:salathe/hide-votes-in-progress branch Jan 4, 2014

bjori added a commit that referenced this pull request Jan 7, 2014

Revert "Merge pull request #1 from salathe/salathe/hide-votes-in-prog…
…ress"

This reverts commit 1baa226, reversing
changes made to 571d084.

bjori added a commit that referenced this pull request Jan 7, 2014

Merge branch 'revert-hide-votes'
Couple of people really did not like this

* revert-hide-votes:
  Revert "Merge pull request #1 from salathe/salathe/hide-votes-in-progress"
  Revert "fix showing your vote"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment