Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set up just to tear down #8

Open
php1ic opened this issue Mar 9, 2019 · 1 comment
Open

Don't set up just to tear down #8

php1ic opened this issue Mar 9, 2019 · 1 comment

Comments

@php1ic
Copy link
Owner

php1ic commented Mar 9, 2019

In the eps file, we set up (set linewidth, colour etc) to draw the r-process, drip lines and magic numbers before checking if they are actually drawn. Thus it's possible that we set-up then tidy-up without actually drawing anything.

Make the necessary changes so this doesn't happen.
@php1ic php1ic changed the title Set up just to tear down Don't set up just to tear down Mar 9, 2019
php1ic added a commit that referenced this issue Jun 18, 2019
@php1ic
Encapsulate the min possible Z value within the class
dffc14b 
The r-process data does not start at Z=1, store the actual value in
the class so that we don't anything we don't need to if the Z range
that is drawn does not encompass it.

Related to #8 & #9
php1ic added a commit that referenced this issue Jun 18, 2019
@php1ic
Encapsulate the min N and Z values in the class
9e8a6b7 
The drip lines do not start at N=0,Z=0 so store their actual start
values within the class.

Realted to #8 & #9
@php1ic
Copy link
Owner Author

php1ic commented Nov 15, 2020

This is fixed for certain cases, but I don't believe it is done for all so will leave this issue open.
I'll try and create some input files to make testing of this simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@php1ic