Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up magic numbers #9

Closed
php1ic opened this issue Mar 9, 2019 · 1 comment
Closed

Clean up magic numbers #9

php1ic opened this issue Mar 9, 2019 · 1 comment

Comments

@php1ic
Copy link
Owner

php1ic commented Mar 9, 2019

Not particle magic number (i.e. 2,8,20 etc)

There are a lot of magic numbers scattered throughout the code, mainly due to the formatting of the data files, e.g position of the mass-excess value in the NUBASE, or the header size for AME.

Look into either refactoring them into a single header (or enum?) or individually per file/mass database.
php1ic added a commit that referenced this issue Jun 18, 2019
@php1ic
Encapsulate the min possible Z value within the class
dffc14b 
The r-process data does not start at Z=1, store the actual value in
the class so that we don't anything we don't need to if the Z range
that is drawn does not encompass it.

Related to #8 & #9
php1ic added a commit that referenced this issue Jun 18, 2019
@php1ic
Encapsulate the min N and Z values in the class
9e8a6b7 
The drip lines do not start at N=0,Z=0 so store their actual start
values within the class.

Realted to #8 & #9
php1ic added a commit that referenced this issue Jun 18, 2019
@php1ic
Various minor changes and updates
144e84c 
- Run clang-format on files that look to have not had it run.
- Make things const if they don't change.
- Give more magic numbers descriptive variable names (#9).
@php1ic
Copy link
Owner Author

php1ic commented Nov 15, 2020

This looks to be done.
There might be one or two hiding somewhere, but they can be removed as they are discovered.

@php1ic php1ic closed this as completed Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@php1ic