Composer And Travis Updates #11
Conversation
phpunit.xml.dist
Outdated
There was a problem hiding this comment.
I prefer that strict be enabled because it helps greatly in doing accurate code coverage reports; is there a reason that you disabled it?
There was a problem hiding this comment.
Yeh. Strict has a different meaning in phpunit 4. It was causing all the tests to be marked a risky.
This is what happened when I tested it before I sent this pull: https://travis-ci.org/GrahamCampbell/GraphViz/jobs/33164111.
There was a problem hiding this comment.
I need to know for sure that when strict is disabled that only code that is covered using an @covers tag is actually shown as being covered. I always understood that was one of the effects of strict. If that proves to be wrong then I'd happily merge it but otherwise this can be tricky.
I don't have the time this evening to test that so that either has to wait until saturday or if you could assert that then it would be awesome!
There was a problem hiding this comment.
PHPUnit4 made strict be even more strict :-D That "risky" classification now means that any code that was executed by a test but was not listed by @covers will result in the test being marked as "risky", which is nearly equivalent to a failure. I guess it's supposed to force you into making your test cases even tighter with regard to the dependencies they touch.
There was a problem hiding this comment.
That can be resolved by setting the "checkForUnintentionallyCoveredCode" setting to false in the phpUnit config file: http://phpunit.de/manual/4.1/en/strict-mode.html
There was a problem hiding this comment.
Do you want me to do that then?
There was a problem hiding this comment.
If you could test if that solves the issue that would be absolutely great!
|
Aside from strict being disabled these are great changes, thank you. I do however use strict for accurate coverage reports (using |
|
Ping @mvriel. I've added back in the safe strict stuff. |
|
Ping @mvriel. |
|
Hi @GrahamCampbell, I am not sure what went wrong there .. Sorry about not responding sooner. This is perfect and merged. Thanks for pinging me again |
No description provided.