-
-
Notifications
You must be signed in to change notification settings - Fork 15
Ci #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci #17
Conversation
Changes Unknown when pulling 0488925 on ashnazg:ci into ** on phpDocumentor:master**. |
I'd like to leave the ECS cleanup for a follow-up PR, one that probably includes adding typehints and return types if needed. The appveyor failure is because graphviz/dot is not available. I'm not sure yet how to deal with that. |
Changes Unknown when pulling 2bb0e26 on ashnazg:ci into ** on phpDocumentor:master**. |
@@ -1,4 +1,14 @@ | |||
GraphViz [](http://travis-ci.org/phpDocumentor/GraphViz) | |||
[](https://opensource.org/licenses/MIT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering: why yellow and not green (since green indicates success and yellow warning)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's just how the badge was written in the list -- https://gist.github.com/lukas-h/2a5d00690736b4c3a7ba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, perhaps you can use https://gitlab.tpip.net/hwinkel/asciidoctor-diagram/commit/da0d51d4b9452f062dabfc05b164fb912c93ed17?view=parallel to install GraphViz in appveyor
The failing testcases are caused by ECS will be fixed in a subsequent effort |
Changes Unknown when pulling d85396d on ashnazg:ci into ** on phpDocumentor:master**. |
Changes Unknown when pulling 7673add on ashnazg:ci into ** on phpDocumentor:master**. |
Changes Unknown when pulling 7673add on ashnazg:ci into ** on phpDocumentor:master**. |
Changes Unknown when pulling bb926ae on ashnazg:ci into ** on phpDocumentor:master**. |
Changes Unknown when pulling 54035ee on ashnazg:ci into ** on phpDocumentor:master**. |
Changes Unknown when pulling 3de55c3 on ashnazg:ci into ** on phpDocumentor:master**. |
Changes Unknown when pulling 3de55c3 on ashnazg:ci into ** on phpDocumentor:master**. |
Changes Unknown when pulling 84f68be on ashnazg:ci into ** on phpDocumentor:master**. |
Changes Unknown when pulling 28469f0 on ashnazg:ci into ** on phpDocumentor:master**. |
No description provided.