Skip to content

Ci #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 10, 2018
Merged

Ci #17

merged 7 commits into from
Jan 10, 2018

Conversation

ashnazg
Copy link
Member

@ashnazg ashnazg commented Jan 10, 2018

No description provided.

@ashnazg ashnazg requested review from mvriel and jaapio January 10, 2018 17:04
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0488925 on ashnazg:ci into ** on phpDocumentor:master**.

@ashnazg
Copy link
Member Author

ashnazg commented Jan 10, 2018

I'd like to leave the ECS cleanup for a follow-up PR, one that probably includes adding typehints and return types if needed.

The appveyor failure is because graphviz/dot is not available. I'm not sure yet how to deal with that.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 2bb0e26 on ashnazg:ci into ** on phpDocumentor:master**.

@@ -1,4 +1,14 @@
GraphViz [![Build Status](https://secure.travis-ci.org/phpDocumentor/GraphViz.png)](http://travis-ci.org/phpDocumentor/GraphViz)
[![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering: why yellow and not green (since green indicates success and yellow warning)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's just how the badge was written in the list -- https://gist.github.com/lukas-h/2a5d00690736b4c3a7ba

Copy link
Member

@mvriel mvriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvriel
Copy link
Member

mvriel commented Jan 10, 2018

The failing testcases are caused by ECS will be fixed in a subsequent effort

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d85396d on ashnazg:ci into ** on phpDocumentor:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7673add on ashnazg:ci into ** on phpDocumentor:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7673add on ashnazg:ci into ** on phpDocumentor:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling bb926ae on ashnazg:ci into ** on phpDocumentor:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 54035ee on ashnazg:ci into ** on phpDocumentor:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3de55c3 on ashnazg:ci into ** on phpDocumentor:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3de55c3 on ashnazg:ci into ** on phpDocumentor:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 84f68be on ashnazg:ci into ** on phpDocumentor:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 28469f0 on ashnazg:ci into ** on phpDocumentor:master**.

@ashnazg ashnazg merged commit 6e20ec2 into phpDocumentor:master Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants