Skip to content

Conversation

ashnazg
Copy link
Member

@ashnazg ashnazg commented Jan 14, 2018

No description provided.

@ashnazg ashnazg requested review from mvriel and jaapio January 14, 2018 22:17
Copy link
Member

@jaapio jaapio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open point of discussion is the phive.xml. Should we commit it or not.

.gitignore Outdated

# By default the phpunit.xml.dist is provided; you can override this using a local config file
phpunit.xml
phive.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phive.xml is like composer.lock for composer. We might consider the commit this to lock our dependencies.

@ashnazg
Copy link
Member Author

ashnazg commented Jan 16, 2018

I think this is ready now.

@jaapio jaapio merged commit 00f872a into phpDocumentor:master Jan 17, 2018
@ashnazg ashnazg deleted the ci branch January 17, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants