Skip to content

Conversation

Julyanvdham
Copy link

This edit makes sure that backslashes are not removed when the chart is made.

This edit makes sure that backslashes are not removed when the chart is made.
@jaapio
Copy link
Member

jaapio commented Apr 11, 2018

Could you please provide a testcase that covers this behavior?

@ashnazg
Copy link
Member

ashnazg commented Aug 7, 2018

NodeTest::testToStringWithLabelContainingSlashes() says that this current behavior is expected:

\\\\phpDocumentor\\\\Descriptor\\\\ProjectDescriptor

After this patch, the result becomes:

\\phpDocumentor\\Descriptor\\ProjectDescriptor

@mvriel @jaapio , is the existing test incorrect in its expected result?

@ashnazg
Copy link
Member

ashnazg commented Aug 7, 2018

Judging from cc37321, this backslashing is intentional.

@jaapio
Copy link
Member

jaapio commented Aug 7, 2018

I don't know if it is intentional. @mvriel could know the answer but it seems to be long time ago that this was introduced. Since this PR doesn't change any tests and does break tests if seems to be invalid to me. Tests are leading for me when in doubt.

@ashnazg
Copy link
Member

ashnazg commented Aug 7, 2018

See AttributeTest::testToStringWithSpecials()... Double backslashes should stay the same is one of the assertion messages. I'm fairly convinced by now that the existing behavior is intentional and correct.

@ashnazg ashnazg closed this Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants