real getters and setters for attributes #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I never looked at this library before. But most patches look sane to me. I have to look at them in detail before I can provide any useful comments. But in general I think it is good to keep this up to date. 👍 |
|
Could you please rebase this PR and add extra tests to fix the coverage drop? |
smoench
changed the title
|
Coverage is back to 100% |
|
Thanks, I will check if we are ready for a new release :-) |
|
@jaapio Is there anything left for a new release or can I help somehow? |
|
Still need to check, I have way too many things to do 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really would like to use this library for https://github.com/sensiolabs-de/deptrac. But I have some trouble with the magic attributes setter and getter. So I would like to contribute real getters and setters for attributes.
Besides I did some more improvements. If there is any interest in those patches I would cherry-pick the commits and create PRs for each of them.