a libary doesn't need a composer.lock file #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashnazg
requested changes
Jun 14, 2019
There was a problem hiding this comment.
A library doesn't need a lock file for its use case of being used as a dependency, sure... but it does need a lock file for its own CI, to control which of its own dependencies are installed during its own development and testing cycles. That's why the lock file is committed.
-1 from me
|
I do agree with @ashnazg. So closing this one without merge. In case you disagree please argue why we should remove it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scrutinizer must be adjusted (allowing none composer.lock file)