Declare some methods by hand to avoid magic #54
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh, seems that the CI is not fully operational here. Only Scrutinizer ran on the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR declare attributes' methods by hand instead of having them in doc. It also create some more that are used in phpDocumentor.
I didn't create every possible attribute (there are 142 of them) so I kept the __call method for the other cases.
I added a string type hint in declaration where it was only a cast before when passing through __call so it's definitely a BC break. I noticed there are a couple of libs that depends on GraphViz... If needed, I can remove the type.