Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more typing #127

Merged
merged 55 commits into from Jun 15, 2018
Merged

add more typing #127

merged 55 commits into from Jun 15, 2018

Conversation

ashnazg
Copy link
Member

@ashnazg ashnazg commented Jun 15, 2018

No description provided.

@ashnazg
update .gitignore
362148e
@ashnazg
clear the risky test warnings
98ac691
@ashnazg
ecs now says this checker is a duplicate;
a1896d6
@ashnazg
ecs --fix
c991522
@ashnazg
list non-camelcased class names to ignore for now
f628cc6
@ashnazg
ecs --fix
d32b8d1
@ashnazg
other ecs can be ignored
56c03dd
@ashnazg
adjust for happiness of both testcases and ecs
f05b9b2
@ashnazg
adjust gitignore for phive usage
c0ee11f
@ashnazg
loosen reflection-docblock dep; remove explicit reflection-common dep;
617a8b6
@ashnazg
drop test phase back out of 'stages';
e657497
@ashnazg
add travis_retry;
180cbd4
@ashnazg
use phive where possible;
71b71f7
@ashnazg
rely on scrunitizer for phpcs
052a5ee
@ashnazg
adjust a few signatures to accommodate new alpha deps
21ef967
@ashnazg
can't install vendor phpunit due to reflection-docblock deps
418bedf
@ashnazg
specify phpunit 6
6fa0469
@ashnazg
add strict typing, return types, and more typehints;
323b731
@ashnazg
additional typing added;
52a4529
@ashnazg
rename to containerMock;
d8bc5cb
@ashnazg
add ProjectFactoryStrategy return;
671dc2a 
adjust testcase mocks to fit;
@ashnazg
ecs removed many param/return tags that are now explicit in the code;
33eff4d
@ashnazg
adjust some docblocks;
53f2fc4
@ashnazg
bump type-resolver
49fc578
@ashnazg
remove tags;
a2d974a
@ashnazg
add string param typehint;
61d1b7d 
null check is redundant;
@ashnazg
add Command interface supertype, for Middleware typehinting;
8d1c210
@ashnazg
bump php versions
43efcf2
@ashnazg
bump reflection-common
21ba8b5
@ashnazg
add develop branch back
b92477a
@ashnazg ashnazg requested a review from jaapio June 15, 2018 15:31
jaapio
jaapio approved these changes Jun 15, 2018
View reviewed changes
Copy link
Member

@jaapio jaapio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way to big to review in detail if all tests are passing there is no reason for me to check all changes.

@ashnazg ashnazg merged commit b7584ea into phpDocumentor:develop Jun 15, 2018
@ashnazg ashnazg deleted the ci2 branch June 15, 2018 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaapio jaapio jaapio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashnazg @jaapio