replace adapters by File objects to be more flexible #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Shouldn't this test the interface and not the concrete instance?
There was a problem hiding this comment.
It is the interface, use phpDocumentor\Reflection\File as FileSystemFile;
There was a problem hiding this comment.
the term Path here might be confusing
|
Missing tests for LocalFile object and CreateCommand? |
|
tests are added now |
mvriel
added a commit
that referenced
this pull request
Dec 27, 2015
replace adapters by File objects to be more flexible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is depending on phpDocumentor/ReflectionCommon#6 therefor a new tag should be created. And the component should be updated in the composer.json/lock