Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to phpunit 9 and drop php 7.2 support #33

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Upgrade to phpunit 9 and drop php 7.2 support #33

merged 1 commit into from
Oct 6, 2020

Conversation

DIOHz0r
Copy link
Contributor

@DIOHz0r DIOHz0r commented Oct 4, 2020 •
edited
Loading

As part of Hacktoberfest, I want to help with issue #32

jaapio
jaapio reviewed Oct 4, 2020
View reviewed changes
composer.json Outdated Show resolved Hide resolved
jaapio
jaapio requested changes Oct 4, 2020
View reviewed changes
Copy link
Member

@jaapio jaapio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR,

I added a small comment about phpunit, and our pipeline has detected an issue. Could you please have a look at those changes?

@DIOHz0r
Copy link
Contributor Author

DIOHz0r commented Oct 5, 2020

Hello, finally all fixes where applied

@jaapio jaapio merged commit 9ac40b2 into phpDocumentor:2.x Oct 6, 2020
@jaapio
Copy link
Member

jaapio commented Oct 6, 2020

Thanks!

@jrfnl jrfnl mentioned this pull request Jul 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaapio jaapio jaapio requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DIOHz0r @jaapio