Skip to content

Conversation

alexandre-le-borgne
Copy link

Surround the creation of the tags of a try catch block to support php doc with unknown tags such as @jms\Type("int"), etc

Surround the creation of the tags of a try catch block to support php doc with unknown tags such as @jms\Type("int"), etc
@Johnmeurt
Copy link

This is useful to fix the support of unkonwn tags but it is not the solution. I was thinking about those 2 solutions:

  • Raise custom exception as UnknownTagException. This could be catch on the DocBlockFactory (same way you did in your commit).
  • Adding an options management in the context. Then adding "ignore_unkonwn_tags" option. This allows the dev to choose the behavior.

@jaapio
Copy link
Member

jaapio commented Aug 4, 2017

I'm clossing this in favor of #110 which is an improved to support annotations in the future.

@jaapio jaapio closed this Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants