getArguments is actually of type array[]

[GrahamCampbell]

No description provided.

[GrahamCampbell]

Unrelated, but is there a reason it was called getArguments instead of getParameters?

[jaapio]

I don't know why this was called originally arguments but it is the term using in all phpdocumentor packages.

For some reason phpstan thinks your change isn't correct. And it needs to be swiched back to string[] maybe because it is an multi-dimensional array. string[][] it should be, I think. Need to check that.

[GrahamCampbell]

It's not of type string[][], because, [$i]['type'] is of type Type.

[GrahamCampbell]

It really is array[]. Not sure why phpstan can't agree.

[GrahamCampbell]

Oh, i see why it inferred that now, it's because the only assignment to it happens to start off life as string[] from one branch. But that inference is incorrect, because it changes type before assignment.

[jaapio]

@ondrejmirtes can you help us here, is this a false report by phpstan?

[ondrejmirtes]

@jaapio If you write array[], that is translated to mixed[][]... Since private $arguments = []; is string[] then these two do not match and something is wrong here...

[jaapio]

Thanks for the quick response @ondrejmirtes!

[ondrejmirtes]

So I'm not sure what you need here, probably just @return array which gets translated into mixed[]?

[GrahamCampbell]

The actual return type is array[] though. It just happens to be that variables that are later assigned to this property have other types in their life before assignment.

[jaapio]

The array has 2 dimensions. where the second dimension is string|Type. Think from a documentation perspective this is not possible yet to define. Cannot find anything in the draft of psr-5.
Keys are even known name|type.

[GrahamCampbell]

The array has 2 dimensions. where the second dimension is string|Type.

Yeh, so the best we can do it say it has type array[], which is the same as mixed[][]?

[jaapio]

Would accept that for now.
A big plus when you even add a proper description ;-)

[GrahamCampbell]

Ha, sorry. :)

[GrahamCampbell]

Could this syntax be what we want: https://github.com/phpDocumentor/TypeResolver/blob/master/tests/unit/TypeResolverTest.php#L376. Does that mean an array of either of those types, but exactly one, or does it mean an array of either of them, if you see what I mean?

[ondrejmirtes]

It’s an array of string|stdClass which means that when you access an item, it will be string or stdClass. If you need an array of strings or an array of stdClasses, you should write string[]|stdClass[].

On Thu, 28 Dec 2017 at 22:30, Graham Campbell ***@***.***> wrote: Could this syntax be what we want: https://github.com/phpDocumentor/TypeResolver/blob/master/tests/unit/TypeResolverTest.php#L376. Does that mean an array of either of those types, but exactly one, or does it mean an array of either of them, if you see what I mean? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#141 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGZuNgz32OmdiI7cnMTwxCkLEUB7ACpks5tFAiLgaJpZM4RN0lV> .

-- Ondřej Mirtes

[jaapio]

Closing because of changed made in #147.