Skip to content

Fixed @method annotations with an empty argument list and description #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2019
Merged

Fixed @method annotations with an empty argument list and description #188

merged 1 commit into from
Dec 20, 2019

Conversation

othercorey
Copy link
Contributor

#174

This also removes some extra characters from the method name character block. I think they were copied from the return types regex up above.

jaapio
jaapio requested changes Dec 19, 2019
View reviewed changes
Copy link
Member

@jaapio jaapio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me. Would like to revert the changes on the existing testcase unless you can explain why those are needed.

@jaapio jaapio self-requested a review December 20, 2019 13:22
@jaapio jaapio merged commit d9e1217 into phpDocumentor:master Dec 20, 2019
@othercorey othercorey deleted the method-arguments branch December 20, 2019 17:04
@alanpoulain alanpoulain mentioned this pull request Dec 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaapio jaapio jaapio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@othercorey @jaapio