Composer And Travis Updates #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the failing test was failing before I sent this pull too. |
|
👍 Excellent stuff |
| - vendor/bin/phpunit | ||
| - composer update --dev --prefer-source | ||
| - composer update --no-interaction --prefer-source --dev |
There was a problem hiding this comment.
why is source preferred on travis? --prefer-dist is much faster...
There was a problem hiding this comment.
Hmm.. I don't remember why anymore. It must have had a reason. Perhaps something to do with the API limit of GitHub? @ashnazg do you remember?
There was a problem hiding this comment.
It is because of api rate limiting.
There was a problem hiding this comment.
dist should pull it from packagist rather than github, shouldn't it?
There was a problem hiding this comment.
@ashnazg No. Dist uses github's api to download a zip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.