Remove composer.lock #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the Composer documentation: > Note: For libraries it is not necessarily recommended to commit the lock file (...) https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file
|
In the past I would have advocated against this practice but given renewed insights and usage patterns I agree that the time has come to remove the lock file. Thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the Composer documentation:
This is because the lock file will only affect people developing this library (not the end-user). If
composer.jsonallows consumers to use a newer version of the dependencies then we should also be testing against that.