Add support for rest argument notation #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the help, Jordi. I agree that it would help to parse this and be able to show it in the docs but not breaking sounds like a good first step ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@method foo(...$arg)breaks it as it tries to parse...as a type, and you end up withInvalidArgumentException: "\...$arg" is not a valid Fqsen.This fixes it by ignoring
...entirely. I suppose it would be nicer to keep track of it as an additional type or something, but it'd be nice if you can merge this as it fixes an issue already, and then work on improvements as needed.