Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change underlying type for StringValue pseudo type #189

Merged
merged 1 commit into from May 30, 2023

Conversation

astronom
Copy link
Contributor

Seems that it is a mistake that StringValue is Float_

In my project I use symfony/serializer with phpdocumentor/reflection-docblock and after upgrade the deserialization of this code sample does not work correctly, because the underlying type of $order is not a String_

final class OrderBy
{
    /**
     * @param 'ASC'|'DESC' $order
     */
    public function __construct(
        private readonly string $order,
    ) {
    }

    /**
     * @return 'ASC'|'DESC'
     */
    public function getOrder(): string
    {
        return $this->order;
    }
}

@astronom
Copy link
Contributor Author

@jaapio plz check this MR

@astronom
Copy link
Contributor Author

@jaapio plz find a few minutes to check this

@jaapio jaapio merged commit b2fe4d2 into phpDocumentor:1.x May 30, 2023
@jaapio
Copy link
Member

jaapio commented May 30, 2023

Thanks for reminding me. This is merge by now

@jaapio
Copy link
Member

jaapio commented May 30, 2023

I just created 1.7.2 as bugfix release. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants