TypeResolver - Ignore whitespaces around tokens

[popy-dev]

This is an attempt to fix issue #49. While fixing it it appeared simpler to update the preg split pattern to match (and ignore) whitespaces everywhere, which means following types will work :

• array<int, string>
• array < int , string >

If it is too open, I can change that to only ignore one|all whitespace after the , token.

I also updated the PREG comment.

[ashnazg]

@popy-dev I think we do want you to restrict this to one space after comma, while not allowing for any additional spaces elsewhere. Also, you may need to rebase against master to clear the conflict.

[ashnazg]

@popy-dev would also be good to adjust test cases to highlight instances of the extra spacing not being allowed.

[popy-dev]

Back from holidays, I'll have a look at this soon. Thanks for feedback !

[popy-dev]

Maybe i should have answered there after I submitted fixes ?

Also, note that travis runs had bugs unrelated to the patch.

[jaapio]

Thanks for the update.I need to check this in detail. To see what is going on. And if all changes are needed.

[jaapio]

Thanks, this looks good.

[bendavies]

this change seems mostly pointless, as https://github.com/phpDocumentor/ReflectionDocBlock splits on whitespace when parsing out @var and @return tags: https://github.com/phpDocumentor/ReflectionDocBlock/blob/master/src/DocBlock/Tags/Var_.php#L56
so for example, given @var Collection<int, Foo>, TypeResolver::resolve('Collection<int') will be called, which will then error.

[jaapio]

could be, but that needs to be fixed in the Docblock component.