Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Group Use Statements #64

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

ragboyjr
Copy link
Contributor

  • Updated namespace parser to handle grouped namespaces

Signed-off-by: RJ Garcia rj@bighead.net

- Updated namespace parser to handle grouped namespaces

Signed-off-by: RJ Garcia <rj@bighead.net>
@jaapio
Copy link
Member

jaapio commented Aug 22, 2018

Thanks, this looks good. I will have a look later this week to see if we can merge and release this.

@@ -14,11 +14,14 @@

// Added imports on purpose as mock for the unit tests, please do not remove.
use \ReflectionClass;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this line to come right after the PHPUnit grouping? That way, the parsing rules will have a line after the grouping to process. I'd like to see how the test goes after that change.

@jaapio jaapio merged commit 51761af into phpDocumentor:master Aug 22, 2018
@jaapio
Copy link
Member

jaapio commented Aug 22, 2018

I checked the change requested by @ashnazg. This is merged to master now.

@natebrunette
Copy link

@jaapio No rush, just curious when we can expect a release.

@jaapio
Copy link
Member

jaapio commented Aug 22, 2018

Think that will be done this week. My day is almost ending, and I have no clue yet when I'm able to finish this merge. There are a number of code style checks failing. That I need to fix before the release

@jaapio
Copy link
Member

jaapio commented Aug 22, 2018

Ok, time to stop for to day.
But the release is there https://github.com/phpDocumentor/TypeResolver/releases/tag/0.7.0

Thanks @ragboyjr for adding this feature.

@ragboyjr ragboyjr deleted the parse-group-use-statements branch August 23, 2018 01:23
@ragboyjr
Copy link
Contributor Author

dude, awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants