Skip to content

Added correct resolver for classes with aliases out of context #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

Pixelycia
Copy link

For example:

<?php 
namespace somens;
use some\other\ns;
class A {
   public function(): ns
   {...}
}

ns will be resolved correctly as some\other\ns not somens\ns.

Such as

<?php 
namespace somens;
use some\other;
class A {
   public function(): other\ns
   {...}
}

ns will be resolved correctly as some\other\ns not somens\other\ns.

aliases but not present in current directory of issued class.
@jaapio
Copy link
Member

jaapio commented Nov 12, 2018

Could you please add a number of tests to cover this new scenario.

@peter279k
Copy link

The Travis CI build is failed.

I think it also checks them and fix the failed CI build.

@othercorey
Copy link
Contributor

@jaapio Is this still an issue?

@jaapio
Copy link
Member

jaapio commented Apr 27, 2020

I don't expect this to be an issue a test has been added in March last year. This test is still passing so I don't know what the original author's issue was. It could be that it was resolved in between with a separate pr.

I will close this PR. @othercorey please open an issue if you have a problem with this library. I will try to respond as soon as possible.

@jaapio jaapio closed this Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants