Psalm: Enable totallyTyped=true and bump type coverage to 100% #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Arg, I don't get the same result locally than on CI. I think we have an old version of Psalm in CI and it's missing some important elements. @jaapio Would you mind bumping Psalm? |
|
I will have a look at how to fix this. |
|
I upgrade psalm, will fix the build on master when needed. But I expect it to pass. |
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforce a little more checks with Psalm
I had to ignore three errors. Two have the same cause: the library doesn't always check ArrayIterator::valid() before calling ArrayIterator::current so it can get a null value. This is not expected by Psalm. It's sort of false positive but caused by a bad practice...
The third I think is legitimate but I didn't take the time to prove it so I'll ignore it for now.