Profiling #96
Merged
Profiling #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
force-pushed
the
feature/blackfire
branch
14 times, most recently
from
2a674d3 to
7eca92b
Compare
jaapio
force-pushed
the
feature/blackfire
branch
from
aa2b3ff to
08f2ad8
Compare
jaapio
force-pushed
the
feature/blackfire
branch
from
08f2ad8 to
079ff0f
Compare
jaapio
force-pushed
the
feature/blackfire
branch
from
079ff0f to
5e6b8dd
Compare
jaapio
force-pushed
the
feature/blackfire
branch
from
7df8882 to
c13fc87
Compare
lolautruche
reviewed
Mar 30, 2020
| - 8707:8707 | ||
| env: | ||
| BLACKFIRE_SERVER_ID: "517a7aa6-1ec8-4d29-bff8-dddecf4333de" | ||
| BLACKFIRE_SERVER_TOKEN: "21795bdce7c0b5d24f0ccbb42e2a7518feb5359840752b163652899f927cbf2b" |
There was a problem hiding this comment.
You should never expose your blackfire credentials (either client or server). This should end up with other secrets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first set of benchmarks using Blackfire to get insights into the performance of this library.
Blackfire will report back to each PR if the impact is acceptable.
I Added a large file from mpdf to test the context factory. Cutting down the number of calls to
ArrayIterator::currentwith more than 50% gave a performance improvement of +/- 60% on this file. In the real world, this gain would be less since the LOC of the processed files is less. But it will still give some improvements on the speed.Please review the changes in the ContextFactory.