small fixes #98
Merged
small fixes #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently, return types are not considered BC breaks so I reverted final declaration |
|
Could you please rebase this PR? |
|
Rebase is done. Profiling is failing for obscure reason |
|
Yeah I need to check the package I'm creating for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some suggestions by PHP EA on PHPStorm
This introduce potentially some BC breaks (return type, final) but another one was committed on master already: 3a0a285#diff-5bcf53cbf788ba443804c35c660f7182R95
We'll just have to make sure the next version is a major?