Upgrade to doctrine/lexer 3 #453
Conversation
|
I would like to have a CI job on all Doctrine projects with the guides-cli running in it, so it's possible to forbid contributors to contribute invalid docs (based on the warnings output to |
composer.lock
Outdated
| @@ -1120,7 +1072,7 @@ | |||
| }, | |||
| { | |||
| "name": "phpdocumentor/guides-cli", | |||
| "version": "dev-main", | |||
| "version": "dev-lexer-3", | |||
There was a problem hiding this comment.
I don't know how to avoid this 🤔
There was a problem hiding this comment.
Fixed by:
- switching to
main - merging my branch
- running the composer command I wanted
- switching back
- committing
- switching back to main
- resetting to
HEAD^
We must keep support for Symfony 5.4, as this library is part of the core phpDocumentor application (which does not yet support Symfony 6). |
This comment was marked as outdated.
This comment was marked as outdated.
| @@ -22,7 +22,7 @@ | |||
| "minimum-stability": "stable", | |||
| "require": { | |||
| "php": "^8.1", | |||
| "doctrine/lexer": "^2.1", | |||
| "doctrine/lexer": "^3.0", | |||
There was a problem hiding this comment.
| "doctrine/lexer": "^3.0", | |
| "doctrine/lexer": "^2.1 || ^3.0", |
Btw, I think only supporting doctrine/lexer 3 is fine (as far as I can see in https://github.com/phpDocumentor/phpDocumentor , only the guides package is using Doctrine lexer).
There was a problem hiding this comment.
You're right, I will change that.
There was a problem hiding this comment.
@wouterj I dropped doctrine/lexer 2 support again.
|
Thanks for the upgrade! |
This should make it easier to install the project on projects with recent dependencies.
This should make it easier to install the project on projects with recent dependencies.