Skip to content

Conversation

greg0ire
Copy link
Contributor

@greg0ire greg0ire commented Jul 5, 2023

Here is the output of composer outdated after this PR:

Direct dependencies required in composer.json:
league/flysystem        1.1.10  3.15.1 Filesystem abstraction: Many filesystems, one API.
league/flysystem-memory 1.0.2   3.15.0 An in-memory adapter for Flysystem.
psr/log                 1.1.4   3.0.0  Common interface for logging libraries
twig/twig               v2.15.5 v3.6.1 Twig, the flexible, fast, and secure template language for PHP

Transitive dependencies not required in composer.json:
amphp/amp               v2.6.2  v3.0.0 A non-blocking concurrency framework for PHP applications.
amphp/byte-stream       v1.8.1  v2.0.1 A stream abstraction to make working with non-blocking I/O simple.
monolog/monolog         2.9.1   3.4.0  Sends your logs to files, sockets, inboxes, databases and various web services
psr/http-message        1.1     2.0    Common interface for HTTP messages

@greg0ire greg0ire mentioned this pull request Jul 5, 2023
@greg0ire greg0ire marked this pull request as draft July 5, 2023 12:36
@greg0ire
Copy link
Contributor Author

greg0ire commented Jul 5, 2023

Converting to draft until I can prove we still test with Symfony 5, or make sure that we do if that's not the case.

@greg0ire
Copy link
Contributor Author

greg0ire commented Jul 5, 2023

Ok, I think there is a big issue here: https://github.com/phpDocumentor/.github/blob/main/.github/workflows/continues-integration.yml#L31-L70

  • matrix.dependencies is never used
  • inputs.composer-dependencies is used but… never defined 😐

@greg0ire
Copy link
Contributor Author

greg0ire commented Jul 5, 2023

Fixed by phpDocumentor/.github#28

@greg0ire
Copy link
Contributor Author

greg0ire commented Jul 5, 2023

Here we can see that Symfony 5 is still being tested: https://github.com/phpDocumentor/guides/actions/runs/5466078620/jobs/9950473579?pr=458#step:5:232

@greg0ire greg0ire marked this pull request as ready for review July 5, 2023 15:25
Copy link
Member

@jaapio jaapio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for enabling this effort. This will help us move forward!

@jaapio jaapio merged commit 3323cf8 into phpDocumentor:main Jul 5, 2023
@greg0ire greg0ire deleted the symfony-6 branch July 5, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants