Skip to content

Fix performance of InlineLexer by delaying URI scheme checking #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2023
Merged

Fix performance of InlineLexer by delaying URI scheme checking #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcc984e
Fix performance of InlineLexer by delaying URI scheme checking
wouterj Jul 13, 2023
495b21f
Merge branch 'main' into speed-up-parser
linawolf Jul 14, 2023
e6feb23
Merge branch 'main' into speed-up-parser
linawolf Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/guides-restructured-text/src/RestructuredText/Parser/InlineLexer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ protected function getCatchablePatterns(): array
return [
'\\\\``', // must be a separate case, as the next pattern would split in "\`" + "`", causing it to become a intepreted text
'\\\\[\s\S]', // Escaping hell... needs escaped slash in regex, but also in php.
ExternalReferenceResolver::SUPPORTED_SCHEMAS . ':[-a-zA-Z0-9()@:%_\\+.~#?&\\/=]*[-a-zA-Z0-9()@%_\\+~#&\\/=]', // standalone hyperlinks
'\\S+@\\S+\\.\\S+',
'[a-z0-9-]+_{2}', //Inline href.
'[a-z0-9-]+_{1}(?=[\s\.+]|$)', //Inline href.
Expand All @@ -76,6 +75,7 @@ protected function getCatchablePatterns(): array
'|',
'\\*\\*',
'\\*',
'\b(?<!:)[a-z0-9\\.\-+]{2,}:[-a-zA-Z0-9()@:%_\\+.~#?&\\/=]*[-a-zA-Z0-9()@%_\\+~#&\\/=]', // standalone hyperlinks
];
}

Expand Down
2 changes: 1 addition & 1 deletion tests/Functional/tests/guilabel/guilabel.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<p>Lorem ipsum dolor sit amet <span class="guilabel">Foo Bar</span>.</p>
<p>Lorem ipsum dolor sit amet<span class="guilabel">Foo Bar</span>.</p>
<p>Lorem ipsum dolor sit amet:guilabel:<code>Foo Bar</code>.</p>
<p>Lorem ipsum dolor sit amet <span class="guilabel">Foo-Bar</span>.</p>
2 changes: 1 addition & 1 deletion tests/Functional/tests/guilabel/guilabel.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ Lorem ipsum dolor sit amet :guilabel:`Foo Bar`.

Lorem ipsum dolor sit amet:guilabel:`Foo Bar`.

Lorem ipsum dolor sit amet :guilabel:`Foo-Bar`.
Lorem ipsum dolor sit amet :guilabel:`Foo-Bar`.