[FEATURE] Facilitate Directive Creation #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A directive can now be created just by supplying a template with the name of that directive in the folder body/directive this behaviour is now similar to how we already did it with Text rules. As an example I transfered the rubric directive to a template-only directive. Such a concept does not exist in other Markup formats anyway. It saves us both the Node and the directive. Additionally this enables us to output unknown directives and then feature a warning (like sphinx does) instead of swallowing it and throwing an error.
jaapio
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A directive can now be created just by supplying a template with the name of that directive in the folder body/directive this behaviour is now similar to how we already did it with Text rules.
As an example I transfered the rubric directive to a template-only directive. Such a concept does not exist in other Markup formats anyway. It saves us both the Node and the directive.
Additionally this enables us to output unknown directives and then feature a warning (like sphinx does) instead of swallowing it and throwing an error.