Skip to content

[FEATURE] Set console option defaults via guides.xml #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2023
Merged

[FEATURE] Set console option defaults via guides.xml #587

merged 1 commit into from
Sep 24, 2023

Conversation

linawolf
Copy link
Contributor

No description provided.

wouterj
wouterj reviewed Sep 12, 2023
View reviewed changes
@linawolf linawolf force-pushed the feature/settings branch 2 times, most recently from c8e980b to fdc1af3 Compare September 23, 2023 10:07
@linawolf linawolf requested a review from wouterj September 23, 2023 10:53
@linawolf
Copy link
Contributor Author

@wouterj I think I understood it, please have another look?

wouterj
wouterj approved these changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@linawolf linawolf merged commit 9cc8baa into main Sep 24, 2023
@linawolf linawolf deleted the feature/settings branch September 24, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@wouterj wouterj wouterj approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linawolf @wouterj