!!![FEATURE] enable basic latex rendering #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
force-pushed
the
feature/latex-rendering
branch
from
d837af0 to
c570165
Compare
linawolf
approved these changes
Nov 3, 2023
To be able to render different formats we needed a more flexible system to pick the correct renderers. The main change in this patch to introduce a OutputAwareDelegatingNodeRenderer as the templates are using a function to render child nodes. Where we lose the connection with the executed renderer. This new OutputAwareDelegatingNodeRenderer will take the output format from the context to select the correct DelegatingNodeRender that will find the correct renderer on its turn to render the node. To make it easier to add custom output formats using other format renders, eg. a single page html, or pdf using the html renderers. the compiler for DI is adjusted. This is now a more advanced compiler pass that will autowire the configured renderers as much as possible.
jaapio
force-pushed
the
feature/latex-rendering
branch
from
c570165 to
19a4e8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to render different formats we needed a more flexible system to pick the correct renderers. The main change in this patch to introduce a OutputAwareDelegatingNodeRenderer as the templates are using a function to render child nodes. Where we lose the connection with the executed renderer.
This new OutputAwareDelegatingNodeRenderer will take the output format from the context to select the correct DelegatingNodeRender that will find the correct renderer on its turn to render the node.
To make it easier to add custom output formats using other format renders, eg. a single page html, or pdf using the html renderers. the compiler for DI is adjusted. This is now a more advanced compiler pass that will autowire the configured renderers as much as possible.