Skip to content

Do not add anchor to URL for document (root) titles #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

wouterj
Copy link
Contributor

@wouterj wouterj commented Dec 24, 2023

We already had a flag for menu entries to mark them as "document root", but it was always set to false. This PR sets it to true when then menu entry references a document root title (in contrast to a sub title within that document).

I've also updated the renderer to not add the anchor when it's a root title. This makes the UX nicer, as you don't need to jump to the document root when you're just navigating to the document start.

@linawolf
Copy link
Contributor

I am skeptical about this. Linking to a HTML page instead of the title only works in single rendering mode. Not when all HTML output is rendered in a single page.

Also at least in TYPO3 we treat sections as independent and they can and are moved around. So we frequently link to them by anchor.

While I do agree to appropriately setting the flag I would not remove the anchors. If for some reason a document does not want to render them, that can be decided in the template. However we do need anchors on a documents main section and use them frequently

@linawolf linawolf self-requested a review December 25, 2023 07:48
@linawolf
Copy link
Contributor

linawolf commented Jan 2, 2024

With #799 Menu entries for pages and sections are different Node types. You should therefore be able to define different templates for them.

@linawolf
Copy link
Contributor

@wouterj closing this, you should be able to solve it with the templates now?

@linawolf linawolf closed this Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants