!![TASK] Improve interlink slug and warning handling #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaapio could you review please? |
jaapio
reviewed
Jan 12, 2024
There was a problem hiding this comment.
I have a few questions and a remark regarding the way you are using exceptions. I must admit that I find it hard to follow what is happening in this part of the code as i'm not very familiar with the interlink code. So please let me know when you think different.
packages/guides/src/ReferenceResolvers/InterlinkReferenceResolver.php
Outdated
Show resolved
Hide resolved
packages/guides/src/ReferenceResolvers/InterlinkReferenceResolver.php
Outdated
Show resolved
Hide resolved
linawolf
force-pushed
the
task/interlink
branch
from
99a9683 to
4b5aa03
Compare
linawolf
changed the title
|
@jaapio please have a look if I applied all changes you intended |
- Add tests - Improve method names, some have been misleading - Always Slug anchors - Do not slug document names (they can be case sensitive etc) This change is breaking for those who extended inventory handling (that should only be TYPO3).
This should make the usage more clear
jaapio
force-pushed
the
task/interlink
branch
from
a7ea823 to
fb562f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is breaking for those who extended inventory handling (that should only be TYPO3).