[!!!TASK] Make all classes final #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linawolf
approved these changes
Jan 21, 2024
|
👍 I see you also made some DTOs final (without interfaces). If these DTOs are part of the public API (either return or parameter type), this can block legitimate extension points (e.g. you can not add new properties to such DTO from a decorator). Not sure if this applies to any of the classes in this PR, but just so you are aware of this. |
|
Thanks @wouterj, I'm aware that this might block extensions, I think we need some extra interfaces, I will review that per case. However I think some of the helper classes will be marked as internal and should never be exposed to the world as they are part of the internals of this libraries. |
This library has a very large number of extension points via interfaces and abstract classes. All other classes should not be extended by users and shall theirfor be marked as final. There are a few classes left that should also be marked as final but those require some extra attention.
jaapio
force-pushed
the
final-all-classes
branch
from
82417c7 to
a7395d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library has a very large number of extension points via interfaces and abstract classes. All other classes should not be extended by users and shall theirfor be marked as final.
There are a few classes left that should also be marked as final but those require some extra attention.