[FEATURE] Get the number of subscribers of list and added tests #116
Conversation
xh3n1
force-pushed
the
subscribers-number
branch
from
8fb00c7 to
79781fa
Compare
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
xh3n1
force-pushed
the
subscribers-number
branch
from
79781fa to
63de167
Compare
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
|
@oliverklee Thank you for the feedback. I think that I have made the requested changes and also added a test for a list without subscribers. |
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
|
Hi @xh3n1, could you please fix the build failures? Then I'll take a look at the updated PR. Thanks! |
|
@oliverklee yes, thanks! |
|
@xh3n1 Do you run the tests locally before you push to GitHub? |
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
xh3n1
force-pushed
the
subscribers-number
branch
from
e61c0f4 to
b5985f6
Compare
|
@oliverklee couldn't run them before because of my environment and it was easier this way. |
xh3n1
changed the title
|
@oliverklee any further changes I should do before this is ready to go? |
You really need to have a local setup where you can run the unit tests, functional tests and style checks. If you need TravisCI to run the tests for you, the feedback loop is far too long for you to work productively and have flow while developing. |
|
@xh3n1 Have you seen this comment?
|
|
@oliverklee It gets only the number of subscribers, and I fixed my local setup to run my tests now. |
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
|
Oh, it looks like this has broken the build. @xh3n1 Would you be willing to look into this? |
|
@oliverklee yes, I know why. Will create a PR later today. |
* change branch name Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com> * Disable REST API by default Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com> * Change path Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com> * Remove prefix Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com> * [FEATURE] Get the number of subscribers of list and added tests (#116) Closes #115 * [BUGFIX] Fix the expected number in an integration test (#119) Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com> * [CLEANUP] Fix a warning with newer PHPMD versions (#125) * update php dependencies * update to pass building * ISSUE-337: update package versions * ISSUE-337: use local * ISSUE-337: symfony 6.4 * ISSUE-337: test fix * ISSUE-337: fix the rest of tests * GitHub actions (#132) * added github workflow(action) for build and test ci tasks Signed-off-by: fenn-cs <fenn25.fn@gmail.com> * updated php_codesniffer dep Signed-off-by: fenn-cs <fenn25.fn@gmail.com> * removed travis ci config file Signed-off-by: fenn-cs <fenn25.fn@gmail.com> (cherry picked from commit 70d45ad) * ISSUE-337: add pipeline * ISSUE-337: fix phpstan * ISSUE-337: fix phpstmd * ISSUE-337: openapi docs * ISSUE-337: move to bundle file * ISSUE-337: changelog * ISSUE-337: update core * ISSUE-337: fix phpstan * ISSUE-337: fix phpcs * ISSUE-337: force push * ISSUE-337: name fix --------- Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com> Co-authored-by: Xheni Myrtaj <myrtajxheni@gmail.com> Co-authored-by: Oliver Klee <oliver@phplist.com> Co-authored-by: Michiel Dethmers <michiel@phplist.com> Co-authored-by: Tatevik <tatevikg1@gmail.com> Co-authored-by: F. E Noel Nfebe <fenn25.fn@gmail.com>
Fix #115