This repository was archived by the owner on Mar 6, 2022. It is now read-only.
Generate method test refactor #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantleech
commented
May 8, 2021
| { | ||
| return [ | ||
| 'Empty file' => [ | ||
| yield 'Empty file' => [ |
There was a problem hiding this comment.
using generator instead
dantleech
commented
May 8, 2021
| $tester->textDocument()->open(self::EXAMPLE_URI, self::EXAMPLE_SOURCE); | ||
|
|
||
| $promise = $tester->workspace()->executeCommand('generate', [self::EXAMPLE_URI, self::EXAMPLE_OFFSET]); | ||
| return $builder; |
There was a problem hiding this comment.
we can add the command and open the text document with the test LS
dantleech
commented
May 8, 2021
|
|
||
| self::assertNotNull($showMessage); | ||
| self::assertEquals([ | ||
| 'type' => 2, | ||
| 'type' => MessageType::WARNING, |
There was a problem hiding this comment.
use the message type constant instead of a magic number
dantleech
commented
May 8, 2021
|
|
||
| $applyEdit = $rpcClient->transmitter()->filterByMethod('workspace/applyEdit')->shiftRequest(); | ||
| $builder = $this->createTester($generateMethod); | ||
| $builder->responseWatcher()->resolveLastResponse(new ApplyWorkspaceEditResponse(true)); |
There was a problem hiding this comment.
the test LS can "respond" to requests.
dantleech
commented
May 8, 2021
|
|
||
| class GenerateMethodCommandTest extends TestCase | ||
| { | ||
| use ProphecyTrait; | ||
| const EXAMPLE_SOURCE = '<?php '; | ||
| const EXAMPLE_URI = 'file:///file.php'; | ||
| const EXAMPLE_OFFSET = 5; |
There was a problem hiding this comment.
use constants instead of local vars (which are acting as constants)
dantleech
commented
May 8, 2021
| $tester = $builder->build(); | ||
| $tester->textDocument()->open(self::EXAMPLE_URI, self::EXAMPLE_SOURCE); | ||
|
|
||
| $promise = $tester->workspace()->executeCommand('generate', [self::EXAMPLE_URI, self::EXAMPLE_OFFSET]); |
There was a problem hiding this comment.
hmm ... this is not right
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @BladeMF