This repository was archived by the owner on Mar 6, 2022. It is now read-only.
Introduce NameImporterResult #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
weeman1337
commented
May 24, 2021
| use Phpactor\LanguageServerProtocol\TextEdit as LspTextEdit; | ||
| use Throwable; | ||
|
|
||
| class NameImporterResult |
There was a problem hiding this comment.
This VO will later be used to transport the name import result back to the completion handler.
|
Sorry I'm slow getting to these.,, when things get busy I loose track |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the journey to "replace completion import command by TextEdits". I am now providing smaller steps to avoid conflicts.
Relates to