Skip to content

Conversation

igorw
Copy link
Contributor

@igorw igorw commented Mar 5, 2011

igorw added 3 commits March 5, 2011 11:52
PHP 5.3 includes the previous pecl extension "intl" which has a native
UTF-8 normalizer.

PHPBB3-9669
Since isNormalized is less expensive than normalize[1] and normalization
will be applied repeatedly in most cases[2], it's more efficient to
check for isNormalized.

[1] http://area51.phpbb.com/phpBB/viewtopic.php?f=81&t=32718&p=208005#p208005
[2] phpBB 3.0 has a call to utf8_normalize_nfc wrapped around any
multibyte request_var call.

PHPBB3-9669
Normalizer::normalize can return null, cast to a string.

PHPBB3-9669
{
if (empty($strings))
/**
* A wrapper function for the normalizer which takes care of including the class if required and modifies the passed strings
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that line is kind of long

}
else
{
/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space vs. Tabs

mungo pushed a commit to mungo/phpbb3 that referenced this pull request Jun 27, 2014
INST_ERR_DB_NO_SQLITE: Aufteilung in zwei Sätze.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants