Skip to content

Fixed installation of sqlsrv and eio PECL packages #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2017
Merged

Fixed installation of sqlsrv and eio PECL packages #9

merged 1 commit into from
Jun 24, 2017

Conversation

morozov
Copy link
Contributor

@morozov morozov commented Jun 23, 2017 •
edited
Loading

  1. Added os and arch as valid dependency types
  2. Removed testing of PHP_Timer and PHPUnit_MockObject as their channels do not exist anymore
  3. Added .gitignore
  4. Added dev-dependency on PHPUnit as otherwise the tests are incompatible with the latest PHPUnit 6

Fixes #5, #6, #8.

@morozov
Fixed installation of sqlsrv and eio PECL packages
e64347a 
1. Added `os` and `arch` as valid dependency types
2. Removed testing of PHP_Timer and PHPUnit_MockObject as their channels do not exist anymore
3. Added .gitignore
4. Added dev-dependency on PHPUnit as otherwise the tests are incompatible with the latest PHPUnit 6

Fixes #6, #8
@c9s c9s merged commit 2d361b3 into phpbrew:master Jun 24, 2017
@c9s
Copy link
Member

c9s commented Jun 24, 2017

Thank you!

@morozov morozov deleted the dependency-types branch June 24, 2017 05:54
@c9s
Copy link
Member

c9s commented Jun 24, 2017

@morozov just curious, would you like to join the phpbrew core team? just wanna invite you to join us 👍

@morozov
Copy link
Contributor Author

morozov commented Jun 24, 2017

@c9s yeah, I'll be glad to join!

@c9s
Copy link
Member

c9s commented Aug 19, 2017

That's great!

@morozov morozov mentioned this pull request Oct 16, 2017
Closed
@ramsey
Copy link

ramsey commented Oct 17, 2017

🎉

jhdxr
jhdxr reviewed Oct 17, 2017
View reviewed changes
.gitignore
@@ -0,0 +1,3 @@
composer.lock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you ignore composer.lock?

Copy link
Contributor Author

@morozov morozov Oct 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's a library, so when used as a dependency, the lock file is ignored. To me, it makes sense to test it alone the same way. Ideally, there should be one more build with composer update --prefer-lowest to make sure the entire range of supported versions is actually supported.

Oh, and it wasn't updated in the repo since 78d2f63 anyways.

@morozov morozov added this to the Release 1.3.4 milestone Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhdxr jhdxr jhdxr left review comments

Assignees

@c9s c9s

Labels
bug enhancement
Projects
None yet
Milestone
Release 1.3.4
Development

Successfully merging this pull request may close these issues.

Attempting to install PECL uuid extension fails
4 participants
@morozov @c9s @ramsey @jhdxr