Skip to content

Do not pass --with-icu-dir to PHP 7.4 #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2019
Merged

Do not pass --with-icu-dir to PHP 7.4 #1032

merged 1 commit into from
Jul 29, 2019

Conversation

morozov
Copy link
Contributor

@morozov morozov commented Jul 25, 2019

PHP 7.4 no longer supports --with-icu-dir (php/php-src#3701).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 40.974% when pulling 7ccf95e on morozov:php74-icu into e5cf9af on phpbrew:master.

@morozov morozov requested review from c9s and jhdxr July 26, 2019 15:41
jhdxr
jhdxr approved these changes Jul 29, 2019
View reviewed changes
Copy link
Member

@jhdxr jhdxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morozov morozov merged commit bceaee1 into phpbrew:master Jul 29, 2019
@morozov morozov deleted the php74-icu branch July 29, 2019 07:55
@morozov morozov self-assigned this Nov 1, 2019
@morozov morozov added this to the Release 1.24 milestone Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhdxr jhdxr jhdxr approved these changes

@c9s c9s Awaiting requested review from c9s

Assignees

@morozov morozov

Labels
Improvement PHP 7.4
Projects
None yet
Milestone
Release 1.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@morozov @coveralls @jhdxr