Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow verification of custom request params #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow verification of custom request params #130

wants to merge 1 commit into from

Conversation

daniel-zahariev
Copy link

No description provided.

@tareqtms
Copy link
Contributor

@daniel-zahariev
Why do you want to do that? The required params here should be coming from Shopify through URL params anyhow.

@daniel-zahariev
Copy link
Author

@tareqtms because i'm building an API for Shopify embedded app and i want to use the Referrer HTTP header and verify that it has valid URL params (they should be sent from Shopify). And in order to do that i want to pass the extracted params to the verification method.

@tareqtms
Copy link
Contributor

tareqtms commented Dec 18, 2019

@daniel-zahariev
Everything sent from Shopify are already available under $_GET variable. What extra you want to add there?
However, if you want you can add your extra parameters to the $_GET variable itself.

@daniel-zahariev
Copy link
Author

The API i'm building is called via JavaScript fetch method and so i want to use the HTTP Referrer header to do the authorisation. Don't think it's the best way to play with $_GET variable.

@joeyhub joeyhub mentioned this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants