Multivalue reference tests #146
Conversation
| public function setUp() | ||
| { | ||
| parent::setUp(); | ||
| $this->renewSession(); // discard changes |
There was a problem hiding this comment.
do we still need this? i think the parent does that
dantleech
force-pushed
the
mixreferenceable
branch
from
ff282cb
to
fd4272a
Compare
| $this->assertSame($referenced2, $this->node->getNode('other-node')->getProperty('reference')->getValue()); | ||
| } | ||
|
|
||
| public function testMultiValueReference() |
There was a problem hiding this comment.
Seems like a data-provider rather than something to test separately, no?
There was a problem hiding this comment.
Yeah.. it should be a data provider, but unfortunately there is some strange magic which happens in this test suite where the fixtures are automatically loaded depending on the "name" of the test method being called - when we use data provider the "name" is returned as testMutlivalueWeakReference data set (array(foo, bar)) or something similar.
And the fixtures are loaded according to that name..
dantleech
force-pushed
the
mixreferenceable
branch
from
fd4272a
to
4203d40
Compare
|
Updated. |
|
hm, this broke even with jackalope/jackalope-doctrine-dbal#231 - i reverted the merge. can you please have another look? |
|
ok .. so the other PR is ok and this test is broken? |
|
i don't know. i assumed that both are fine, merged this and restarted the tests on the jackalope PR. then both jackalope dbal master and the PR had the same errors, so i am assuming the problem is with the changes in here. but could also be something went wrong and the tests are meant to fail without the fix, and the jackalope PR somehow does not correctly fix the problem. |
Added multivalue reference test