Added method to get a nodes localname

[dantleech]

Added method to retrieve the localname for a node from a given path.

[dbu]

looks ok. what is the use case? i am wondering a bit if we should not expect a node name instead of a path... or we could say it can be either and first check if there is a / in the parameter and if not treat the whole param as a node name.

[dantleech]

the use case may or not be a valid one, in jackalope-fs I want to index the localname - but as I already index the path I'm not sure thats necessary, but I am still learning what is and is not possible with Zend Lucene.

[dbu]

for jackalope, the node name should usually be including the namespace i guess. but i think if we can support both path and just a full name where we only have to remove the namespace, i am +1 on having this. might be we actually do such splits in jackalope for some reason already.

[dbu]

do you think you manage to support both path and just a name in one method?

[lsmith77]

ping .. guess it would be good to resolve this for 1.2.0 stable

[dbu]

what i mean by my comment: could we make this method work with both absolute paths and full names as parameter, to return the local name regardless of what was the argument? we could maybe just strrpos from the end of the string for either : or / whichever is first, and the whole string if none, and take the last segment. then we have no validation if this is a valid name / path but would handle a lot without much effort.

[dantleech]

@dbu well accepting a node name would make the behavior different from getNodeName which only accepts absolute paths.

[dbu]

this is an invalid name. i would not have a test for this situation. (if anything, this should lead to an exception)

[dantleech]

Removed.

[dbu]

@dantleech okay. if the local name method makes sense for you as it is, lets keep it that way then.

i added a new comment for the test with an invalid node name.

[lsmith77]

so good to merge so that we can tag a stable release?

[dantleech]

Have removed the invalid test - not sure it should be the responsiblity of that helper method to validate the node name, in anycase getNodeName does not.