[WIP] Test lowest versions of vendor packages #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wouterj
commented
Dec 19, 2014
wouterj
commented
- Added tests for the lowest versions allowed by the composer.json
- Updated the version constraints so that they only allow truly supported versions
- Bumped the PHP version up to 5.3.3, as you can never proof that you support 5.3.0 (it is no longer supported by Travis). It didn't make sense too, since Symfony Console is requiring 5.3.3.
- Added tests for PHP 5.6
wouterj
changed the title
In 2.0.4, the lowest version available on Packagist, there was no valid autoloading set up. This means that version isn't really usable.
|
Haha, I had to update to symfony/console 2.0.5, because 2.0.4 didn't configure the Composer autoloader (so resulting in "Class not found" errors). |
|
All tests pass now. Can this please be merged, followed by a new minor release with this included in 1.1.x and 1.2.x? |
dbu
added a commit
that referenced
this pull request
Dec 20, 2014
[WIP] Test lowest versions of vendor packages
|
thanks a lot, great work! tagged 1.1.2 and created #142 for master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.