Added support for only removing children #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dantleech
commented
Apr 13, 2013
dantleech
commented
- Also tidied up messages
- Also tidied up messages
There was a problem hiding this comment.
can we call this only-children to make it clear? otherwise somebody not familiar with PHPCR could think he can delete a node without the children...
There was a problem hiding this comment.
purge /cms/content
purge children /cms/content
purge children-of /cms/content
purge only-children /cms/content
Hmm. I think I agree with you. Although I prefer the terser syntax. Ideally I would love to have some bash like syntax, for example
purge /cms/content/*
purge /cms/{medias,chronology,content} # delete each of medias, chrology and content
But not sure how much of that would need to be escaped.
There was a problem hiding this comment.
yeah i think globs would be expanded by the shell unless you quote them. depends probably on the shell...
purge /cms/content --only-children seems not too bad to me, can you change that and we merge?
dbu
added a commit
that referenced
this pull request
Apr 16, 2013
Added support for only removing children
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.