Bump PHP version to 7 and add typehinting #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. I imagine, tests should be relatively easy to fix too. Though it may be somewhat tedious. |
|
Tests can be fixed quite easily yes, but I am currently swamped. Will handle them later this afternoon. Will update this PR. |
The HHVM team announced that HHVM will never truly support PHP7, in the light of this I have added the hhvm to the allowed failures list in traves. Source: http://hhvm.com/blog/2017/09/18/the-future-of-hhvm.html
|
Great job, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #4 requested, these changes bump the version in the composer.json file, and add typehints to all the classes and interfaces.
The tests are unfortunately now broken, since your curl_* mocks are more often than not returning strings instead of bool or int values as the originals.