Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicPath item can be seen if there is a sibling file to the @dynamic file #17

Closed
g105b opened this issue Mar 16, 2022 · 3 comments
Closed

DynamicPath item can be seen if there is a sibling file to the @dynamic file #17

g105b opened this issue Mar 16, 2022 · 3 comments
Assignees
@g105b
Labels
bug Something isn't working

Comments

@g105b
Copy link
Member

g105b commented Mar 16, 2022

In a directory with a @dynamic.html, if there is a non-dynamic.php, it can call DynamicPath::get() and it will be returned with its own name, rather than null.
@g105b g105b added the bug Something isn't working label Mar 16, 2022
@g105b g105b self-assigned this Apr 1, 2022
@g105b
Copy link
Member Author

g105b commented Apr 1, 2022 •
edited
Loading

The bug is confined to this condition returning true when it shouldn't:

Routing/src/Path/FileMatch/BasicFileMatch.php

Line 19 in 495aa20

return true;

It's matching the dynamic file within the subdirectory incorrectly, as the actual directory contains a matching file.

g105b added a commit to PhpGt/WebEngine that referenced this issue Apr 2, 2022
@g105b
add extra filter, for PhpGt/Routing#17
ba85382
@g105b
Copy link
Member Author

g105b commented Apr 11, 2022

PhpGt/WebEngine@ba85382 should fix this. Waiting for the next project to use this extensively before closing.

@g105b
Copy link
Member Author

g105b commented Apr 27, 2022

Tested and confirmed working.

@g105b g105b closed this as completed Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g105b g105b

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@g105b