PhpMetrics v2.0.0 warnings on analyze folder

[clagiordano]

/usr/local/bin/phpmetrics --version
PhpMetrics v2.0.0 <http://phpmetrics.org>
by Jean-François Lépine <https://twitter.com/Halleck45>

using this command:

/usr/local/bin/phpmetrics --report-html=build/metrics ./src/

text output seems to be correct but it returns same repetitive warning, i think, on output html report:

PHP Warning:  array_push() expects parameter 1 to be array, float given in phar:///usr/local/bin/phpmetrics/src/Hal/Metric/Consolidated.php on line 95
PHP Stack trace:
PHP   1. {main}() /usr/local/bin/phpmetrics:0
PHP   2. Hal\Application\Application->run() /usr/local/bin/phpmetrics:16
PHP   3. Hal\Report\Html\Reporter->generate() phar:///usr/local/bin/phpmetrics/src/Hal/Application/Application.php:67
PHP   4. Hal\Metric\Consolidated->__construct() phar:///usr/local/bin/phpmetrics/src/Hal/Report/Html/Reporter.php:44
PHP   5. array_push() phar:///usr/local/bin/phpmetrics/src/Hal/Metric/Consolidated.php:95

and

PHP Warning:  array_push() expects parameter 1 to be array, float given in phar:///usr/local/bin/phpmetrics/src/Hal/Metric/Consolidated.php on line 95
PHP Stack trace:
PHP   1. {main}() /usr/local/bin/phpmetrics:0
PHP   2. Hal\Application\Application->run() /usr/local/bin/phpmetrics:16
PHP   3. Hal\Report\Html\Reporter->generate() phar:///usr/local/bin/phpmetrics/src/Hal/Application/Application.php:67
PHP   4. Hal\Metric\Consolidated->__construct() phar:///usr/local/bin/phpmetrics/src/Hal/Report/Html/Reporter.php:44
PHP   5. array_push() phar:///usr/local/bin/phpmetrics/src/Hal/Metric/Consolidated.php:95
PHP Warning:  array_sum() expects parameter 1 to be array, float given in phar:///usr/local/bin/phpmetrics/src/Hal/Metric/Consolidated.php on line 103

thanks for your work!

[Halleck45]

Hi,

I cannot reproduce :(.

Can you debug manually please, as following ?

1. git clone https://github.com/phpmetrics/PhpMetrics.git && cd PhpMetrics
2. edit the file src/Hal/Metric/Consolidated.php line 94

// file src/Hal/Metric/Consolidated.php line 94
foreach ($avg as $k => &$a) {
    if(!is_array($avg->$k)) {
         var_dump($k);
         var_dump($avg->$k);
    }
    array_push($avg->$k, $item->get($k));
}

1. run php ./bin/phpmetrics --report-html=build/metrics ./src/
2. and finally copy-paste the output in this issue ?

Or can you provide the files you're analyzing ?

Thank's a lot !

[clagiordano]

I cloned the repo on the branch master but I see this:

PhpMetrics [master|✔] 
$ php ./bin/phpmetrics --version
PhpMetrics, by Jean-François Lépine (https://twitter.com/Halleck45) version v1.10.0

is the correct branch for the v2 source code?

[clagiordano]

I see the commit log history ad the right branch seems to be version2_ast

PhpMetrics [version2_ast|✔] 
$ php bin/phpmetrics --version
PhpMetrics v2.0.0 <http://phpmetrics.org>
by Jean-François Lépine <https://twitter.com/Halleck45>

[clagiordano]

A little suggestion, after cloning branch or pull new commits I usually exec command

composer install

but in this case I need to execute

composer update

because the composer.lock file is ignore by into .gitignore file, then my suggestion is:

I recently discovered that it is a better solution to keep composer.lock files under version control for better consistency of installed libraries and to be sure that on all environment there are exactly the same versions of the libraries installed, this obviously implies the need to commiting changes after each composer update because composer.lock will be updated.

Thanks!

[clagiordano]

See #236 for more informations.

I replaced on Consolidated class:

foreach ($avg as $k => &$a) {
    array_push($avg->$k, $item->get($k));
}

with your provided code:

foreach ($avg as $k => &$a) {
    if (!is_array($avg->$k)) {
        var_dump($k);
        var_dump($avg->$k);
    }
    array_push($avg->$k, $item->get($k));
}

and the var_dump outputs this:

PhpMetrics/src/Hal/Metric/Consolidated.php:96:
string(3) "ccn"
PhpMetrics/src/Hal/Metric/Consolidated.php:97:
double(7)

however phpmetrics works:

HTML report generated in "build/metrics" directory

Done

Reports seems to be generated correctly.

My test environment:

$ lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description:    Debian GNU/Linux unstable (sid)
Release:    unstable
Codename:   sid

$ php --version
PHP 7.0.8-3 (cli) ( NTS )
Copyright (c) 1997-2016 The PHP Group
Zend Engine v3.0.0, Copyright (c) 1998-2016 Zend Technologies
    with Zend OPcache v7.0.8-3, Copyright (c) 1999-2016, by Zend Technologies
    with Xdebug v2.4.0, Copyright (c) 2002-2016, by Derick Rethans

the source code used for this tests is a my public library package and could be found here:
https://github.com/clagiordano/weblibs-configmanager

for any questions or help please do not hesitate to contact me.

Thanks.

[Halleck45]

Oups, sorry for the incorrect instructions :/

Thanks for your help. I'll fix it soon

[clagiordano]

No problem, just a tips.

Thanks for your work

[Halleck45]

@clagiordano Ok I've reproduced this warning with your code and under PHP7.0.

I don't know why, but this commit fixed it.

Can you confirm that this issue is fixed ?

[clagiordano]

Perfect, now works fine!

Thanks!