Upgrade PHP_CodeSniffer to v3 #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
|
Looks good, let's hope it won't break anything (given that this doesn't have testsuite). |
nijel
added a commit
to phpmyadmin/phpmyadmin
that referenced
this pull request
Sep 28, 2017
See phpmyadmin/coding-standard#3 and phpmyadmin/coding-standard#5 Signed-off-by: Michal Čihař <michal@cihar.com>
nijel
added a commit
to phpmyadmin/phpmyadmin
that referenced
this pull request
Sep 28, 2017
See phpmyadmin/coding-standard#3 and phpmyadmin/coding-standard#5 Signed-off-by: Michal Čihař <michal@cihar.com>
|
Seems it doesn't work as expected on Jenkins (see https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/13608/console#ant-target-5): |
nijel
added a commit
to phpmyadmin/phpmyadmin
that referenced
this pull request
Sep 28, 2017
We really do not want to use potentially older version installed on the system. See phpmyadmin/coding-standard#5 Signed-off-by: Michal Čihař <michal@cihar.com>
|
Ah, it was using older phpcs installed on the system. Should be fixed in phpmyadmin/phpmyadmin@656127c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3
Signed-off-by: Maurício Meneghini Fauth mauriciofauth@gmail.com